From: Michael Brown <mcb30@ipxe.org>
Date: Mon, 4 Jul 2016 15:13:25 +0000 (+0100)
Subject: [downloader] Treat redirection failures as fatal
X-Git-Tag: v1.20.1~404
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=89c6db838fc795c113e0584de0230cf86225135b;p=thirdparty%2Fipxe.git

[downloader] Treat redirection failures as fatal

Debugged-by: Robin Smidsrød <robin@smidsrod.no>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
---

diff --git a/src/core/downloader.c b/src/core/downloader.c
index ba678f868..35b5b0ac6 100644
--- a/src/core/downloader.c
+++ b/src/core/downloader.c
@@ -190,14 +190,18 @@ static int downloader_vredirect ( struct downloader *downloader, int type,
 
 		/* Set image URI */
 		if ( ( rc = image_set_uri ( downloader->image, uri ) ) != 0 )
-			return rc;
+			goto err;
 	}
 
 	/* Redirect to new location */
 	if ( ( rc = xfer_vreopen ( &downloader->xfer, type, args ) ) != 0 )
-		return rc;
+		goto err;
 
 	return 0;
+
+ err:
+	downloader_finished ( downloader, rc );
+	return rc;
 }
 
 /** Downloader data transfer interface operations */