From: Frédéric Buclin Date: Thu, 28 Oct 2010 15:27:58 +0000 (+0200) Subject: Bug 607966: Use of qw(...) as parentheses is deprecated since Perl 5.13.5 X-Git-Tag: bugzilla-3.6.3~4 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=89da800c5368aacf158a6f6a0dde3f5ea5ceb7fd;p=thirdparty%2Fbugzilla.git Bug 607966: Use of qw(...) as parentheses is deprecated since Perl 5.13.5 r=gerv a=LpSolit --- diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index a3343a2f27..3cd5a38224 100644 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -1251,7 +1251,7 @@ sub _check_dependencies { my %deps_in = (dependson => $depends_on || '', blocked => $blocks || ''); - foreach my $type qw(dependson blocked) { + foreach my $type (qw(dependson blocked)) { my @bug_ids = ref($deps_in{$type}) ? @{$deps_in{$type}} : split(/[\s,]+/, $deps_in{$type}); diff --git a/Bugzilla/CGI.pm b/Bugzilla/CGI.pm index 4a8140df3b..eec5df3745 100644 --- a/Bugzilla/CGI.pm +++ b/Bugzilla/CGI.pm @@ -171,9 +171,7 @@ sub clean_search_url { foreach my $num (1,2) { # If there's no value in the email field, delete the related fields. if (!$self->param("email$num")) { - foreach my $field qw(type assigned_to reporter qa_contact - cc longdesc) - { + foreach my $field (qw(type assigned_to reporter qa_contact cc longdesc)) { $self->delete("email$field$num"); } } diff --git a/chart.cgi b/chart.cgi index 0b46347b5e..b4c82adae1 100755 --- a/chart.cgi +++ b/chart.cgi @@ -200,7 +200,7 @@ elsif ($action eq "delete") { $series->remove_from_db(); # Remove (sub)categories which no longer have any series. - foreach my $cat qw(category subcategory) { + foreach my $cat (qw(category subcategory)) { my $is_used = $dbh->selectrow_array("SELECT COUNT(*) FROM series WHERE $cat = ?", undef, $series->{"${cat}_id"}); if (!$is_used) {