From: Gert Doering <gert@greenie.muc.de>
Date: Sat, 9 Apr 2011 16:16:21 +0000 (+0200)
Subject: Add more detailed explanation regarding the function of "--rdns-internal"
X-Git-Tag: v2.2.0~14
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=89e0728ba6057bfe45b635a42c36502e9edc8cb3;p=thirdparty%2Fopenvpn.git

Add more detailed explanation regarding the function of "--rdns-internal"

As agreed in last thursday's IRC meeting [1], I've added a comment to the
code explaining "--rdns-internal".  It's really very much an internal
option, so it does not need to go to the man page.

[1] http://thread.gmane.org/gmane.network.openvpn.devel/4573

Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: David Sommerseth <davids@redhat.com>
Signed-off-by: David Sommerseth <davids@redhat.com>
(cherry picked from commit cdb3a5c0864e0fe8d0b814de1f024fd624dd3b1c)
---

diff --git a/options.c b/options.c
index 36e839339..1117a0a75 100644
--- a/options.c
+++ b/options.c
@@ -5343,7 +5343,13 @@ add_option (struct options *options,
       VERIFY_PERMISSION (OPT_P_IPWIN32);
       options->tuntap_options.register_dns = true;
     }
-  else if (streq (p[0], "rdns-internal")) /* standalone method for internal use */
+  else if (streq (p[0], "rdns-internal"))
+     /* standalone method for internal use
+      *
+      * (if --register-dns is set, openvpn needs to call itself in a
+      *  sub-process to execute the required functions in a non-blocking
+      *  way, and uses --rdns-internal to signal that to itself)
+      */
     {
       VERIFY_PERMISSION (OPT_P_GENERAL);
       set_debug_level (options->verbosity, SDL_CONSTRAIN);