-Go back to the query page. -"; +Go back to the query page."; exit; }; /^asnamed$/ && do { if ($::FORM{'newqueryname'} =~ /^[a-zA-Z0-9_ ]+$/) { print "Set-Cookie: QUERY_" . $::FORM{'newqueryname'} . "=$::buffer ; path=/ ; expires=Sun, 30-Jun-2029 00:00:00 GMT -Content-type: text/html\n\n"; +Content-type: text/html -PutHeader("OK, done."); -print " + +
-Go back to the query page. -"; + +Go back to the query page."; } else { - print "Content-type: text/html\n\n"; + print "Content-type: text/html -PutHeader("Picky, picky."); -print " + +
@@ -118,15 +112,15 @@ Click the Back button and type in a valid name for this query."; }; /^asdefault$/ && do { print "Set-Cookie: DEFAULTQUERY=$::buffer ; path=/ ; expires=Sun, 30-Jun-2029 00:00:00 GMT -Content-type: text/html\n\n"; +Content-type: text/html -PutHeader("OK, default is set."); -print " + +
-Go back to the query page, using the new default."; +Go back to the query page, using the new default."; exit; }; } @@ -231,8 +225,7 @@ if (defined $::FORM{'sql'}) { } } else { my $ref = $::MFORM{$field}; - foreach my $vv (@$ref) { - my $v = url_decode($vv); + foreach my $v (@$ref) { if ($v eq "(empty)") { $query .= "\t\t${or}bugs.$field is null\n"; } else { @@ -335,20 +328,20 @@ if (defined $::FORM{'order'}) { } if ($dotweak) { - pnl "
- + To make changes to a bunch of bugs at once: Put check boxes next to the bugs you want to change. @@ -597,15 +590,15 @@ To make changes to a bunch of bugs at once: comment explaining what you're doing.) Click the below \"Commit\" button. - +
-Back to query page.\n"; +Back to query page.\n"; diff --git a/colchange.cgi b/colchange.cgi index 32fe1bb43c..bd3b23d6f4 100755 --- a/colchange.cgi +++ b/colchange.cgi @@ -24,6 +24,8 @@ use strict; require "CGI.pl"; +print "Content-type: text/html\n"; + # The master list not only says what fields are possible, but what order # they get displayed in. @@ -47,8 +49,8 @@ if (defined $::FORM{'rememberedquery'}) { my $list = join(" ", @collist); print "Set-Cookie: COLUMNLIST=$list ; path=/ ; expires=Sun, 30-Jun-2029 00:00:00 GMT\n"; print "Refresh: 0; URL=buglist.cgi?$::FORM{'rememberedquery'}\n"; - print "Content-type: text/html\n\n"; - PutHeader("What a hack"); + print "\n"; + print "
\n"; -print "
\n"; print "\n"; print "
\n"; -print "Edit the owners some more.\n
\n"; -print "Go back to the query page.\n"; +print "Edit the owners some more.
\n"; +print "Go back to the query page.\n"; diff --git a/doeditparams.cgi b/doeditparams.cgi index 514fdbd7d8..e43fd73ce5 100755 --- a/doeditparams.cgi +++ b/doeditparams.cgi @@ -70,6 +70,6 @@ foreach my $i (@::param_list) { WriteParams(); print "OK, done.
\n"; -print "Edit the params some more.\n
\n"; -print "Go back to the query page.\n"; +print "Edit the params some more.
\n"; +print "Go back to the query page.\n"; diff --git a/editowners.cgi b/editowners.cgi index 647bdeda02..1bfb6ac136 100755 --- a/editowners.cgi +++ b/editowners.cgi @@ -44,9 +44,9 @@ PutHeader("Edit Component Owners"); print "This lets you edit the owners of the program components of bugzilla.\n"; -print "
Skip all this, and go back to the query page\n"; +print "
Skip all this, and go back to the query page\n"; diff --git a/editparams.cgi b/editparams.cgi index b000719564..f926c0ae97 100755 --- a/editparams.cgi +++ b/editparams.cgi @@ -49,23 +49,23 @@ print "Be careful!\n"; print "
\n"; print "Any item you check Reset on will get reset to its default value.\n"; -print "
Skip all this, and go back to the query page\n"; diff --git a/enter_bug.cgi b/enter_bug.cgi index 893a992da5..529c394b85 100755 --- a/enter_bug.cgi +++ b/enter_bug.cgi @@ -43,9 +43,9 @@ if (!defined $::FORM{'product'}) { print "a bug.\n"; print "
Click Back and try again.\n"; exit; @@ -229,7 +231,7 @@ my $basequery = $::query; sub SnapShotBug { my ($id) = (@_); SendSQL("select " . join(',', @::log_columns) . - " from bugs where bug_id = '" . $id . "'"); + " from bugs where bug_id = $id"); return FetchSQLData(); } @@ -238,7 +240,7 @@ foreach my $id (@idlist) { SendSQL("lock tables bugs write, bugs_activity write, cc write, profiles write"); my @oldvalues = SnapShotBug($id); - my $query = "$basequery\nwhere bug_id = '" . $id . "'"; + my $query = "$basequery\nwhere bug_id = $id"; # print "
$query
$q
\n"; - print "Back To BUG# $id\n"; - print "Back To Query Page\n"; - print "Enter a new bug\n"; + print "
+
-
@@ -221,27 +216,27 @@ print " - Run this query + Run this query "; if ($namelist ne "") { print " -
-Back to the query page. +Back to the query page. "; exit; diff --git a/reports.cgi b/reports.cgi index 12ff00c7f4..7456c054ed 100755 --- a/reports.cgi +++ b/reports.cgi @@ -156,12 +156,11 @@ FIN sub most_doomed { my $when = localtime (time); - my $product = url_decode($::FORM{'product'}); print < -Bug Report for $product +Bug Report for $::FORM{'product'} $when FIN @@ -180,7 +179,7 @@ from bugs, versions projector where bugs.assigned_to = assign.userid and bugs.reporter = report.userid -and bugs.product='$product' +and bugs.product='$::FORM{'product'}' and ( bugs.bug_status = 'NEW' or @@ -394,13 +393,13 @@ sub header FIN } -sub show_chart { - my $when = localtime (time); - my $product = url_decode($::FORM{'product'}); +sub show_chart + { + my $when = localtime (time); - if (! is_legal_product($product)) + if (! is_legal_product ($::FORM{'product'})) { - &die_politely ("Unknown product: $product"); + &die_politely ("Unknown product: $::FORM{'product'}"); } print < "Bug Charts for $product", + "title" => "Bug Charts for $::FORM{'product'}", "x_label" => "Dates", "y_label" => "Bug Count", "legend_labels" => \@labels, @@ -477,7 +476,6 @@ FIN sub die_politely { my $msg = shift; - my $product = url_decode($::FORM{'product'}); print < @@ -486,7 +484,7 @@ sub die_politely Sorry, but ... -There is no graph available for $product +There is no graph available for $::FORM{'product'} $msg diff --git a/sanitycheck.cgi b/sanitycheck.cgi index 102e017b75..814a1f031d 100755 --- a/sanitycheck.cgi +++ b/sanitycheck.cgi @@ -18,7 +18,6 @@ # Netscape Communications Corporation. All Rights Reserved. # # Contributor(s): Terry Weissman -# Andrew Anderson use diagnostics; use strict; @@ -43,7 +42,7 @@ sub Alert { sub BugLink { my ($id) = (@_); - return "$id"; + return "$id"; } diff --git a/show_bug.cgi b/show_bug.cgi index 06e02da2bb..98829e356c 100755 --- a/show_bug.cgi +++ b/show_bug.cgi @@ -22,19 +22,16 @@ use diagnostics; use strict; -use vars @::FORM; +print "Content-type: text/html\n"; +print "\n"; require "CGI.pl"; -confirm_login(); - -print "Content-type: text/html\n\n"; - -if (!defined $::FORM{'id'} || $::FORM{'id'} eq "") { - PutHeader("Search By Bug Number", "Search By Bug Number", ""); - print "\n"; +if (!defined $::FORM{'id'}) { + print "Search By Bug Number\n"; + print "\n"; print "You may find a single bug by entering its bug id here: \n"; - print "\n"; + print "\n"; print "\n"; print "\n"; exit;
FIN @@ -180,7 +179,7 @@ from bugs, versions projector where bugs.assigned_to = assign.userid and bugs.reporter = report.userid -and bugs.product='$product' +and bugs.product='$::FORM{'product'}' and ( bugs.bug_status = 'NEW' or @@ -394,13 +393,13 @@ sub header FIN } -sub show_chart { - my $when = localtime (time); - my $product = url_decode($::FORM{'product'}); +sub show_chart + { + my $when = localtime (time); - if (! is_legal_product($product)) + if (! is_legal_product ($::FORM{'product'})) { - &die_politely ("Unknown product: $product"); + &die_politely ("Unknown product: $::FORM{'product'}"); } print < "Bug Charts for $product", + "title" => "Bug Charts for $::FORM{'product'}", "x_label" => "Dates", "y_label" => "Bug Count", "legend_labels" => \@labels, @@ -477,7 +476,6 @@ FIN sub die_politely { my $msg = shift; - my $product = url_decode($::FORM{'product'}); print < @@ -486,7 +484,7 @@ sub die_politely Sorry, but ... -There is no graph available for $product +There is no graph available for $::FORM{'product'} $msg diff --git a/sanitycheck.cgi b/sanitycheck.cgi index 102e017b75..814a1f031d 100755 --- a/sanitycheck.cgi +++ b/sanitycheck.cgi @@ -18,7 +18,6 @@ # Netscape Communications Corporation. All Rights Reserved. # # Contributor(s): Terry Weissman -# Andrew Anderson use diagnostics; use strict; @@ -43,7 +42,7 @@ sub Alert { sub BugLink { my ($id) = (@_); - return "$id"; + return "$id"; } diff --git a/show_bug.cgi b/show_bug.cgi index 06e02da2bb..98829e356c 100755 --- a/show_bug.cgi +++ b/show_bug.cgi @@ -22,19 +22,16 @@ use diagnostics; use strict; -use vars @::FORM; +print "Content-type: text/html\n"; +print "\n"; require "CGI.pl"; -confirm_login(); - -print "Content-type: text/html\n\n"; - -if (!defined $::FORM{'id'} || $::FORM{'id'} eq "") { - PutHeader("Search By Bug Number", "Search By Bug Number", ""); - print "\n"; +if (!defined $::FORM{'id'}) { + print "Search By Bug Number\n"; + print "\n"; print "You may find a single bug by entering its bug id here: \n"; - print "\n"; + print "\n"; print "\n"; print "\n"; exit;
-There is no graph available for $product
+There is no graph available for $::FORM{'product'}
$msg diff --git a/sanitycheck.cgi b/sanitycheck.cgi index 102e017b75..814a1f031d 100755 --- a/sanitycheck.cgi +++ b/sanitycheck.cgi @@ -18,7 +18,6 @@ # Netscape Communications Corporation. All Rights Reserved. # # Contributor(s): Terry Weissman -# Andrew Anderson use diagnostics; use strict; @@ -43,7 +42,7 @@ sub Alert { sub BugLink { my ($id) = (@_); - return "$id"; + return "$id"; } diff --git a/show_bug.cgi b/show_bug.cgi index 06e02da2bb..98829e356c 100755 --- a/show_bug.cgi +++ b/show_bug.cgi @@ -22,19 +22,16 @@ use diagnostics; use strict; -use vars @::FORM; +print "Content-type: text/html\n"; +print "\n"; require "CGI.pl"; -confirm_login(); - -print "Content-type: text/html\n\n"; - -if (!defined $::FORM{'id'} || $::FORM{'id'} eq "") { - PutHeader("Search By Bug Number", "Search By Bug Number", ""); - print "\n"; +if (!defined $::FORM{'id'}) { + print "Search By Bug Number\n"; + print "\n"; print "You may find a single bug by entering its bug id here: \n"; - print "\n"; + print "\n"; print "\n"; print "\n"; exit;