From: Peter Krempa <pkrempa@redhat.com>
Date: Fri, 4 Mar 2022 13:37:13 +0000 (+0100)
Subject: qemuSnapshotCreateAlignDisks: Rewrite logic for selecting default memory snapshot... 
X-Git-Tag: v8.2.0-rc1~122
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8a0e9e106b5b2db642a265a5747cd16892b7d7cf;p=thirdparty%2Flibvirt.git

qemuSnapshotCreateAlignDisks: Rewrite logic for selecting default memory snapshot mode

Use an if/else branch rather than a expression with a ternary operator.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index f92b571b06..355a2fd782 100644
--- a/src/qemu/qemu_snapshot.c
+++ b/src/qemu/qemu_snapshot.c
@@ -1672,9 +1672,10 @@ qemuSnapshotCreateAlignDisks(virDomainObj *vm,
             return -1;
         }
 
-        def->memory = (def->state == VIR_DOMAIN_SNAPSHOT_SHUTOFF ?
-                       VIR_DOMAIN_SNAPSHOT_LOCATION_NONE :
-                       VIR_DOMAIN_SNAPSHOT_LOCATION_INTERNAL);
+        if (def->state == VIR_DOMAIN_SNAPSHOT_SHUTOFF)
+            def->memory = VIR_DOMAIN_SNAPSHOT_LOCATION_NONE;
+        else
+            def->memory = VIR_DOMAIN_SNAPSHOT_LOCATION_INTERNAL;
     }
     if (virDomainSnapshotAlignDisks(def, NULL, align_location, true) < 0)
         return -1;