From: Miod Vallat <miod.vallat@powerdns.com>
Date: Fri, 16 Jan 2026 07:20:18 +0000 (+0100)
Subject: Use rfc1982LessThanOrEqual rather than rolling our own. NFCI
X-Git-Tag: rec-5.4.0-beta1~40^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8a1771df0d8ab49116f9b626a0e93fa6a898f838;p=thirdparty%2Fpdns.git

Use rfc1982LessThanOrEqual rather than rolling our own. NFCI

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---

diff --git a/pdns/ixfrdist.cc b/pdns/ixfrdist.cc
index e167554f21..e9824aa7f1 100644
--- a/pdns/ixfrdist.cc
+++ b/pdns/ixfrdist.cc
@@ -925,7 +925,7 @@ static bool handleIXFR(int fd, const MOADNSParser& mdp, const shared_ptr<const S
 
   uint32_t ourLatestSerial = zoneInfo->soa->d_st.serial;
 
-  if (rfc1982LessThan(ourLatestSerial, clientSOA->d_st.serial) || ourLatestSerial == clientSOA->d_st.serial) {
+  if (rfc1982LessThanOrEqual(ourLatestSerial, clientSOA->d_st.serial)) {
     /* RFC 1995 Section 2
      *    If an IXFR query with the same or newer version number than that of
      *    the server is received, it is replied to with a single SOA record of