From: Alan T. DeKok <aland@freeradius.org>
Date: Mon, 20 Aug 2012 09:29:09 +0000 (+0200)
Subject: Clarify error message
X-Git-Tag: release_2_2_0~67
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8a21246524ef11351cd1f3104696a4f9a588f726;p=thirdparty%2Ffreeradius-server.git

Clarify error message
---

diff --git a/src/main/evaluate.c b/src/main/evaluate.c
index d14e9581a5b..fd0a5950ecc 100644
--- a/src/main/evaluate.c
+++ b/src/main/evaluate.c
@@ -80,6 +80,8 @@ static const char *expand_string(char *buffer, size_t sizeof_buffer,
 					     buffer, sizeof_buffer, NULL,
 					     NULL, 0);
 		if (result != 0) {
+			radlog(L_ERR, "Failed to execute program in string expansion: %s",
+			       value);
 			return NULL;
 		}
 
@@ -728,8 +730,6 @@ int radius_evaluate_condition(REQUEST *request, int modreturn, int depth,
 			pleft = expand_string(xleft, sizeof(xleft), request,
 					      lt, left);
 			if (!pleft) {
-				radlog(L_ERR, "Failed expanding string at: %s",
-				       left);
 				return FALSE;
 			}
 		}
@@ -817,8 +817,6 @@ int radius_evaluate_condition(REQUEST *request, int modreturn, int depth,
 			pright = expand_string(xright, sizeof(xright), request,
 					       rt, right);
 			if (!pright) {
-				radlog(L_ERR, "Failed expanding string at: %s",
-				       right);
 				return FALSE;
 			}
 		}