From: Al Viro Date: Thu, 26 Nov 2015 20:20:19 +0000 (-0500) Subject: ext4: fix an endianness bug in ext4_encrypted_zeroout() X-Git-Tag: v4.3.6~49 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8a744287bd6b9cccd25423112ea7322bb47c4c01;p=thirdparty%2Fkernel%2Fstable.git ext4: fix an endianness bug in ext4_encrypted_zeroout() commit e2c9e0b28e146c9a3bce21408f3c02e24ac7ac31 upstream. ex->ee_block is not host-endian (note that accesses of other fields of *ex right next to that line go through the helpers that do proper conversion from little-endian to host-endian; it might make sense to add similar for ->ee_block to avoid reintroducing that kind of bugs...) Signed-off-by: Al Viro Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/ext4/crypto.c b/fs/ext4/crypto.c index 2fab243a4c9e9..7d6cda4738a4f 100644 --- a/fs/ext4/crypto.c +++ b/fs/ext4/crypto.c @@ -408,7 +408,7 @@ int ext4_encrypted_zeroout(struct inode *inode, struct ext4_extent *ex) struct ext4_crypto_ctx *ctx; struct page *ciphertext_page = NULL; struct bio *bio; - ext4_lblk_t lblk = ex->ee_block; + ext4_lblk_t lblk = le32_to_cpu(ex->ee_block); ext4_fsblk_t pblk = ext4_ext_pblock(ex); unsigned int len = ext4_ext_get_actual_len(ex); int ret, err = 0;