From: Alan T. DeKok <aland@freeradius.org>
Date: Tue, 17 May 2022 13:19:33 +0000 (-0400)
Subject: close on error.  Fixes #4518
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8a84b0d1fb32289590102118d88abce0ca4cad7b;p=thirdparty%2Ffreeradius-server.git

close on error.  Fixes #4518
---

diff --git a/src/modules/rlm_mruby/rlm_mruby.c b/src/modules/rlm_mruby/rlm_mruby.c
index 42f82a151a6..d16e9d26169 100644
--- a/src/modules/rlm_mruby/rlm_mruby.c
+++ b/src/modules/rlm_mruby/rlm_mruby.c
@@ -195,11 +195,11 @@ static int mod_instantiate(module_inst_ctx_t const *mctx)
 	}
 
 	status = mrb_load_file(mrb, f);
+	fclose(f);
 	if (mrb_undef_p(status)) {
 		ERROR("Parsing file failed");
 		return -1;
 	}
-	fclose(f);
 
 	status = mrb_funcall(mrb, mrb_obj_value(inst->mruby_module), "instantiate", 0);
 	if (mrb_undef_p(status)) {