From: Peter Krempa Date: Tue, 20 Jan 2015 16:01:01 +0000 (+0100) Subject: CVE-2015-0236: qemu: Check ACLs when dumping security info from snapshots X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8abca887b19600b6652654a01a78455afd4d8294;p=thirdparty%2Flibvirt.git CVE-2015-0236: qemu: Check ACLs when dumping security info from snapshots The ACL check didn't check the VIR_DOMAIN_XML_SECURE flag and the appropriate permission for it. Found via code inspection while fixing permissions for save images. (cherry picked from commit b347c0c2a321ec5c20aae214927949832a288c5a) --- diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 4c1753bac1..6a20850a00 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -12863,7 +12863,7 @@ static char *qemuDomainSnapshotGetXMLDesc(virDomainSnapshotPtr snapshot, if (!(vm = qemuDomObjFromSnapshot(snapshot))) goto cleanup; - if (virDomainSnapshotGetXMLDescEnsureACL(snapshot->domain->conn, vm->def) < 0) + if (virDomainSnapshotGetXMLDescEnsureACL(snapshot->domain->conn, vm->def, flags) < 0) goto cleanup; if (!(snap = qemuSnapObjFromSnapshot(vm, snapshot))) diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x index 7986b4e45c..e7b66cae01 100644 --- a/src/remote/remote_protocol.x +++ b/src/remote/remote_protocol.x @@ -4184,6 +4184,7 @@ enum remote_procedure { * @generate: both * @priority: high * @acl: domain:read + * @acl: domain:read_secure:VIR_DOMAIN_XML_SECURE */ REMOTE_PROC_DOMAIN_SNAPSHOT_GET_XML_DESC = 186,