From: Christoph Hellwig Date: Sat, 14 Oct 2023 05:50:35 +0000 (+0200) Subject: xfs: skip always_cow inodes in xfs_reflink_trim_around_shared X-Git-Tag: v6.15-rc1~149^2~7^2~5^2~33 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8ae4c8cec0bb4f437c16ba5f4b4d63a1f3a87062;p=thirdparty%2Fkernel%2Fstable.git xfs: skip always_cow inodes in xfs_reflink_trim_around_shared xfs_reflink_trim_around_shared tries to find shared blocks in the refcount btree. Always_cow inodes don't have that tree, so don't bother. For the existing always_cow code this is a minor optimization. For the upcoming zoned code that can do COW without the rtreflink code it avoids triggering a NULL pointer dereference. Signed-off-by: Christoph Hellwig Reviewed-by: "Darrick J. Wong" --- diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index b21cb0d36dd44..fd65e5d7994a5 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c @@ -235,7 +235,7 @@ xfs_reflink_trim_around_shared( int error = 0; /* Holes, unwritten, and delalloc extents cannot be shared */ - if (!xfs_is_cow_inode(ip) || !xfs_bmap_is_written_extent(irec)) { + if (!xfs_is_reflink_inode(ip) || !xfs_bmap_is_written_extent(irec)) { *shared = false; return 0; }