From: Andreas Schneider <asn@samba.org>
Date: Thu, 4 Apr 2024 09:28:39 +0000 (+0200)
Subject: s4:dns_server: Use lpcfg_dns_hostname() in dlz_bind9.c
X-Git-Tag: tdb-1.4.11~591
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8ae565a14b59dbd7c67a0bc19e89b8ea1393e41a;p=thirdparty%2Fsamba.git

s4:dns_server: Use lpcfg_dns_hostname() in dlz_bind9.c

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/dns_server/dlz_bind9.c b/source4/dns_server/dlz_bind9.c
index 409e2f30dff..02de7dae796 100644
--- a/source4/dns_server/dlz_bind9.c
+++ b/source4/dns_server/dlz_bind9.c
@@ -240,6 +240,7 @@ static bool b9_format(struct dlz_bind9_data *state,
 		break;
 
 	case DNS_TYPE_SOA: {
+		const char *dns_hostname = NULL;
 		const char *mname;
 		*type = "soa";
 
@@ -247,13 +248,11 @@ static bool b9_format(struct dlz_bind9_data *state,
 		 * point at ourselves. This is how AD DNS servers
 		 * force clients to send updates to the right local DC
 		 */
-		mname = talloc_asprintf(mem_ctx, "%s.%s.",
-					lpcfg_netbios_name(state->lp),
-					lpcfg_dnsdomain(state->lp));
-		if (mname == NULL) {
+		dns_hostname = lpcfg_dns_hostname(state->lp);
+		if (dns_hostname == NULL) {
 			return false;
 		}
-		mname = strlower_talloc(mem_ctx, mname);
+		mname = talloc_asprintf(mem_ctx, "%s.", dns_hostname);
 		if (mname == NULL) {
 			return false;
 		}