From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Thu, 9 Apr 2020 21:07:04 +0000 (+0300)
Subject: login-proxy: login_proxy_new() - Change host check to assert
X-Git-Tag: 2.3.11.2~204
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8af087a63449807d9c581ed6a3139211f4dcc3f2;p=thirdparty%2Fdovecot%2Fcore.git

login-proxy: login_proxy_new() - Change host check to assert

It's already checked by the only caller.
---

diff --git a/src/login-common/login-proxy.c b/src/login-common/login-proxy.c
index 5b255e9da1..5a93cceb8f 100644
--- a/src/login-common/login-proxy.c
+++ b/src/login-common/login-proxy.c
@@ -324,14 +324,9 @@ int login_proxy_new(struct client *client, struct event *event,
 {
 	struct login_proxy *proxy;
 
+	i_assert(set->host != NULL && set->host[0] != '\0');
 	i_assert(client->login_proxy == NULL);
 
-	if (set->host == NULL || *set->host == '\0') {
-		e_error(event, "host not given");
-		event_unref(&event);
-		return -1;
-	}
-
 	if (client->proxy_ttl <= 1) {
 		e_error(event, "TTL reached zero - proxies appear to be looping?");
 		event_unref(&event);