From: Antonio Quartulli Date: Mon, 5 Apr 2021 12:28:27 +0000 (+0200) Subject: ssl: remove unneeded if block X-Git-Tag: v2.6_beta1~548 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8af7c6b2d79b63ef5587ef1bc4ec81834905698e;p=thirdparty%2Fopenvpn.git ssl: remove unneeded if block There is no need to check the result of a boolean function and then assign a constant value to a variable based on that check. Directly assign the return value of the function to the variable. Signed-off-by: Antonio Quartulli Acked-by: Gert Doering Message-Id: <20210405122827.16836-1-a@unstable.cc> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg22045.html Signed-off-by: Gert Doering --- diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 9d18c6e5b..d8662d000 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -1592,7 +1592,6 @@ openvpn_PRF(const uint8_t *secret, uint8_t *output, int output_len) { - bool ret = true; /* concatenate seed components */ struct buffer seed = alloc_buf(strlen(label) @@ -1614,10 +1613,8 @@ openvpn_PRF(const uint8_t *secret, } /* compute PRF */ - if (!ssl_tls1_PRF(BPTR(&seed), BLEN(&seed), secret, secret_len, output, output_len)) - { - ret = false; - } + bool ret = ssl_tls1_PRF(BPTR(&seed), BLEN(&seed), secret, secret_len, + output, output_len); buf_clear(&seed); free_buf(&seed);