From: Tim Wiederhake <twiederh@redhat.com>
Date: Mon, 1 Feb 2021 12:42:07 +0000 (+0100)
Subject: vircommand: Simplify virCommandAddArg
X-Git-Tag: v7.1.0-rc1~333
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8b1755024b1051816cb37532dbf507584ecb2e4c;p=thirdparty%2Flibvirt.git

vircommand: Simplify virCommandAddArg

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index c3a98bbeac..b1a26f68aa 100644
--- a/src/util/vircommand.c
+++ b/src/util/vircommand.c
@@ -1520,8 +1520,6 @@ virCommandAddEnvXDG(virCommandPtr cmd, const char *baseDir)
 void
 virCommandAddArg(virCommandPtr cmd, const char *val)
 {
-    char *arg;
-
     if (!cmd || cmd->has_error)
         return;
 
@@ -1530,16 +1528,13 @@ virCommandAddArg(virCommandPtr cmd, const char *val)
         return;
     }
 
-    arg = g_strdup(val);
-
     /* Arg plus trailing NULL. */
     if (VIR_RESIZE_N(cmd->args, cmd->maxargs, cmd->nargs, 1 + 1) < 0) {
-        VIR_FREE(arg);
         cmd->has_error = ENOMEM;
         return;
     }
 
-    cmd->args[cmd->nargs++] = arg;
+    cmd->args[cmd->nargs++] = g_strdup(val);
 }