From: Greg Hudson <ghudson@mit.edu>
Date: Sun, 12 Mar 2017 16:29:50 +0000 (-0400)
Subject: Fix memory leaks in test programs
X-Git-Tag: krb5-1.16-beta1~135
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8b1f9f64159add28ab03a35a7a98f9f17664322f;p=thirdparty%2Fkrb5.git

Fix memory leaks in test programs

Eliminate memory leaks detected by asan in test programs (and
introduced since commit 4947c270032691d556140b290e1b10846b692968), to
make it easier to find more serious leaks.
---

diff --git a/src/kdc/t_replay.c b/src/kdc/t_replay.c
index 87dbbc6420..fe49560eda 100644
--- a/src/kdc/t_replay.c
+++ b/src/kdc/t_replay.c
@@ -620,6 +620,8 @@ test_kdc_check_lookaside_hit(void **state)
     assert_true(data_eq(rep, *result_data));
     assert_int_equal(hits, 1);
     assert_int_equal(e->num_hits, 1);
+
+    krb5_free_data(context, result_data);
 }
 
 static void
@@ -697,6 +699,8 @@ test_kdc_check_lookaside_hit_multiple(void **state)
     assert_int_equal(e1->num_hits, 1);
     assert_int_equal(e2->num_hits, 0);
 
+    krb5_free_data(context, result_data);
+
     /* Set result_data so we can verify that it is reset to NULL. */
     result_data = &req1;
     result = kdc_check_lookaside(context, &req2, &result_data);
@@ -730,6 +734,8 @@ test_kdc_check_lookaside_hit_hash_collision(void **state)
     assert_int_equal(e1->num_hits, 1);
     assert_int_equal(e2->num_hits, 0);
 
+    krb5_free_data(context, result_data);
+
     /* Set result_data so we can verify that it is reset to NULL. */
     result_data = &req1;
     result = kdc_check_lookaside(context, &req2, &result_data);
diff --git a/src/tests/icinterleave.c b/src/tests/icinterleave.c
index d76ecf3616..a1bdd3547f 100644
--- a/src/tests/icinterleave.c
+++ b/src/tests/icinterleave.c
@@ -119,6 +119,10 @@ main(int argc, char **argv)
         }
     }
 
+    for (i = 0; i < nclients; i++)
+        krb5_free_data_contents(ctx, &reps[i]);
+    free(reps);
+    free(iccs);
     krb5_free_context(ctx);
     return 0;
 }