From: Daniel Salzman <daniel.salzman@nic.cz>
Date: Wed, 27 May 2020 11:49:14 +0000 (+0200)
Subject: xdp-gun: improve popen return handling to mute Clang analyzer
X-Git-Tag: v3.0.0~102^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8b2ee368fb476f767dfd997e5a9946d8e9462b04;p=thirdparty%2Fknot-dns.git

xdp-gun: improve popen return handling to mute Clang analyzer
---

diff --git a/src/utils/xdp-gun/main.c b/src/utils/xdp-gun/main.c
index e8d2395054..0ddaec05ec 100644
--- a/src/utils/xdp-gun/main.c
+++ b/src/utils/xdp-gun/main.c
@@ -343,9 +343,10 @@ static int ip_route_get(const char *ip, const char *what, char **res)
 	char cmd[50 + strlen(ip) + strlen(what)];
 	(void)snprintf(cmd, sizeof(cmd), "ip route get %s | grep -o ' %s [^ ]* '", ip, what);
 
+	errno = 0;
 	FILE *p = popen(cmd, "r");
 	if (p == NULL) {
-		return knot_map_errno();
+		return (errno != 0) ? knot_map_errno() : KNOT_ENOMEM;
 	}
 
 	char check[16] = { 0 }, got[256] = { 0 };