From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 22 Apr 2024 15:32:51 +0000 (+0200)
Subject: test: ensure all architecture ids we define definitely fit into .v/ patterns
X-Git-Tag: v256-rc1~61
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8b2f2a568d39755ff97a0a0c8b9e17ec564f24dc;p=thirdparty%2Fsystemd.git

test: ensure all architecture ids we define definitely fit into .v/ patterns

Just some safety checks so that we never regress on this: make sure all
architectur IDs we define are embeddable safely in .v/ entry file names.
---

diff --git a/src/test/test-architecture.c b/src/test/test-architecture.c
index b245e862c82..6b7777d284e 100644
--- a/src/test/test-architecture.c
+++ b/src/test/test-architecture.c
@@ -3,6 +3,7 @@
 #include "architecture.h"
 #include "errno-util.h"
 #include "log.h"
+#include "path-util.h"
 #include "tests.h"
 #include "virt.h"
 
@@ -49,5 +50,17 @@ int main(int argc, char *argv[]) {
 
         log_info("primary library architecture=" LIB_ARCH_TUPLE);
 
+        for (Architecture i = 0; i < _ARCHITECTURE_MAX; i++) {
+                const char *n = ASSERT_PTR(architecture_to_string(i));
+
+                /* Let's validate that all architecture names we define are good for inclusion in .v/
+                 * filename patterns which use "." and "_" as field separators in the filenames. */
+                assert(filename_part_is_valid(n));
+                assert(!strchr(n, '_'));
+                assert(!strchr(n, '.'));
+
+                log_info("Good for inclusion in .v/ filenames: %s", n);
+        }
+
         return 0;
 }