From: Thorsten Blum <thorsten.blum@linux.dev>
Date: Mon, 26 Jan 2026 17:50:18 +0000 (+0100)
Subject: crypto: rng - Use unregister_rngs in register_rngs
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8b3ad41479b07d2b677f14a91358aaf804f740c3;p=thirdparty%2Fkernel%2Flinux.git

crypto: rng - Use unregister_rngs in register_rngs

Replace the for loop with a call to crypto_unregister_rngs(). Return
'ret' immediately and remove the goto statement to simplify the error
handling code.  No functional changes.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/crypto/rng.c b/crypto/rng.c
index 5982dcea1010b..c6165c8eb3873 100644
--- a/crypto/rng.c
+++ b/crypto/rng.c
@@ -202,17 +202,13 @@ int crypto_register_rngs(struct rng_alg *algs, int count)
 
 	for (i = 0; i < count; i++) {
 		ret = crypto_register_rng(algs + i);
-		if (ret)
-			goto err;
+		if (ret) {
+			crypto_unregister_rngs(algs, i);
+			return ret;
+		}
 	}
 
 	return 0;
-
-err:
-	for (--i; i >= 0; --i)
-		crypto_unregister_rng(algs + i);
-
-	return ret;
 }
 EXPORT_SYMBOL_GPL(crypto_register_rngs);