From: Ralf Habacker <ralf.habacker@freenet.de>
Date: Tue, 5 May 2015 15:08:18 +0000 (+0200)
Subject: auth_set_unix_credentials: Fix calling _dbus_credentials_add_unix_uid without checkin... 
X-Git-Tag: dbus-1.9.16~29
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8b5788b2c2c03b890c8d462075fc215617a88bf6;p=thirdparty%2Fdbus.git

auth_set_unix_credentials: Fix calling _dbus_credentials_add_unix_uid without checking return value (CID 54722).

Reported by Coverity: CID 54722: Unchecked return value (CHECKED_RETURN)

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90021
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
---

diff --git a/dbus/dbus-auth-script.c b/dbus/dbus-auth-script.c
index 03be4e20b..fdbe1fe48 100644
--- a/dbus/dbus-auth-script.c
+++ b/dbus/dbus-auth-script.c
@@ -221,7 +221,10 @@ auth_set_unix_credentials(DBusAuth  *auth,
     _dbus_assert_not_reached ("no memory");
 
   if (uid != DBUS_UID_UNSET)
-    _dbus_credentials_add_unix_uid (credentials, uid);
+    {
+      if (!_dbus_credentials_add_unix_uid (credentials, uid))
+        _dbus_assert_not_reached ("no memory");
+    }
   if (pid != DBUS_PID_UNSET)
     _dbus_credentials_add_pid (credentials, pid);