From: lpsolit%gmail.com <>
Date: Fri, 18 Mar 2005 16:36:08 +0000 (+0000)
Subject: Bug 178157: Dependency emails don't get sent for status change during mass change... 
X-Git-Tag: bugzilla-2.18.1~23
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8b834559c47be66e315d58ced9fdce48d2ecda92;p=thirdparty%2Fbugzilla.git

Bug 178157: Dependency emails don't get sent for status change during mass change - Patch by Frederic Buclin <LpSolit@gmail.com> r=myk a=justdave
---

diff --git a/process_bug.cgi b/process_bug.cgi
index 217bff5b4a..d36f813f47 100755
--- a/process_bug.cgi
+++ b/process_bug.cgi
@@ -1455,18 +1455,17 @@ foreach my $id (@idlist) {
     # change or the status or resolution change. This var keeps track of that.
     my $check_dep_bugs = 0;
 
-    if (defined $::FORM{'dependson'}) {
-        my $me = "blocked";
-        my $target = "dependson";
-        for (1..2) {
-            SendSQL("select $target from dependencies where $me = $id order by $target");
+    foreach my $pair ("blocked/dependson", "dependson/blocked") {
+        my ($me, $target) = split("/", $pair);
+
+        my @oldlist = @{$dbh->selectcol_arrayref("SELECT $target FROM dependencies
+                                                  WHERE $me = ? ORDER BY $target",
+                                                  undef, $id)};
+        @dependencychanged{@oldlist} = 1;
+
+        if (defined $::FORM{'dependson'}) {
             my %snapshot;
-            my @oldlist;
-            while (MoreSQLData()) {
-                push(@oldlist, FetchOneColumn());
-            }
             my @newlist = sort {$a <=> $b} @{$deps{$target}};
-            @dependencychanged{@oldlist} = 1;
             @dependencychanged{@newlist} = 1;
 
             while (0 < @oldlist || 0 < @newlist) {
@@ -1501,10 +1500,6 @@ foreach my $id (@idlist) {
                 LogDependencyActivity($id, $oldsnap, $target, $me);
                 $check_dep_bugs = 1;
             }
-
-            my $tmp = $me;
-            $me = $target;
-            $target = $tmp;
         }
     }