From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Tue, 26 Nov 2024 09:25:11 +0000 (+0100)
Subject: improve error messages a bit
X-Git-Tag: rec-5.2.0-rc1~31^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8b9d0180585096d2c0ecf959aff1569edc90502b;p=thirdparty%2Fpdns.git

improve error messages a bit
---

diff --git a/pdns/dnsdistdist/dnsdist-metrics.cc b/pdns/dnsdistdist/dnsdist-metrics.cc
index 89f13bef65..434088df4e 100644
--- a/pdns/dnsdistdist/dnsdist-metrics.cc
+++ b/pdns/dnsdistdist/dnsdist-metrics.cc
@@ -206,7 +206,7 @@ std::variant<uint64_t, Error> incrementCustomCounter(const std::string_view& nam
     metric->second.d_value += step;
     return metric->second.d_value.load();
   }
-  return std::string("Unable to increment custom metric '") + std::string(name) + "': no such metric";
+  return std::string("Unable to increment custom metric '") + std::string(name) + "': no such counter";
 }
 
 std::variant<uint64_t, Error> decrementCustomCounter(const std::string_view& name, uint64_t step)
@@ -217,7 +217,7 @@ std::variant<uint64_t, Error> decrementCustomCounter(const std::string_view& nam
     metric->second.d_value -= step;
     return metric->second.d_value.load();
   }
-  return std::string("Unable to decrement custom metric '") + std::string(name) + "': no such metric";
+  return std::string("Unable to decrement custom metric '") + std::string(name) + "': no such counter";
 }
 
 std::variant<double, Error> setCustomGauge(const std::string_view& name, const double value)
@@ -229,7 +229,7 @@ std::variant<double, Error> setCustomGauge(const std::string_view& name, const d
     return value;
   }
 
-  return std::string("Unable to set metric '") + std::string(name) + "': no such metric";
+  return std::string("Unable to set metric '") + std::string(name) + "': no such gauge";
 }
 
 std::variant<double, Error> getCustomMetric(const std::string_view& name)