From: Douglas Bagnall Date: Wed, 22 May 2019 21:59:51 +0000 (+1200) Subject: dsdb/password_hash: don't double assign variables (CID 1363048, 1034720) X-Git-Tag: samba-4.13.0rc1~73 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8bd7669d8d2b313502a8556943f0cff22c08f960;p=thirdparty%2Fsamba.git dsdb/password_hash: don't double assign variables (CID 1363048, 1034720) Signed-off-by: Douglas Bagnall Reviewed-by: Andreas Schneider Reviewed-by: Ralph Boehme Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Mon Jul 6 13:56:17 UTC 2020 on sn-devel-184 --- diff --git a/source4/dsdb/samdb/ldb_modules/password_hash.c b/source4/dsdb/samdb/ldb_modules/password_hash.c index 00f21307d90..bfdfa51595a 100644 --- a/source4/dsdb/samdb/ldb_modules/password_hash.c +++ b/source4/dsdb/samdb/ldb_modules/password_hash.c @@ -2456,8 +2456,8 @@ static int setup_password_fields(struct setup_password_fields_io *io) { struct ldb_context *ldb = ldb_module_get_ctx(io->ac->module); struct loadparm_context *lp_ctx = - lp_ctx = talloc_get_type(ldb_get_opaque(ldb, "loadparm"), - struct loadparm_context); + talloc_get_type(ldb_get_opaque(ldb, "loadparm"), + struct loadparm_context); int ret; ret = setup_last_set_field(io); @@ -2708,8 +2708,8 @@ static int check_password_restrictions(struct setup_password_fields_io *io, WERR struct ldb_context *ldb = ldb_module_get_ctx(io->ac->module); int ret; struct loadparm_context *lp_ctx = - lp_ctx = talloc_get_type(ldb_get_opaque(ldb, "loadparm"), - struct loadparm_context); + talloc_get_type(ldb_get_opaque(ldb, "loadparm"), + struct loadparm_context); *werror = WERR_INVALID_PARAMETER;