From: Max Kanat-Alexander <mkanat@bugzilla.org>
Date: Sat, 10 Jul 2010 05:07:51 +0000 (-0700)
Subject: Bug 577602: Don't put multi-select fields into the GROUP BY in Search.pm,
X-Git-Tag: bugzilla-4.1.1~431
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8bdb86fdce8ad3b177a81f3cf07bf026e2faa0e2;p=thirdparty%2Fbugzilla.git

Bug 577602: Don't put multi-select fields into the GROUP BY in Search.pm,
because they are created by an aggregate. (This fixes multi-select buglist
columns on Pg.)
r=mkanat, a=mkanat (module owner)
---

diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm
index 63e4586553..c41579efe4 100644
--- a/Bugzilla/Search.pm
+++ b/Bugzilla/Search.pm
@@ -1119,8 +1119,12 @@ sub init {
     foreach my $field (@fields) {
         # These fields never go into the GROUP BY (bug_id goes in
         # explicitly, below).
-        next if (grep($_ eq $field, EMPTY_COLUMN, 
-                      qw(bug_id actual_time percentage_complete flagtypes.name keywords)));
+        my @skip_group_by = (EMPTY_COLUMN, 
+            qw(bug_id actual_time percentage_complete flagtypes.name
+               keywords));
+        push(@skip_group_by, map { $_->name } @$multi_select_fields);
+
+        next if grep { $_ eq $field } @skip_group_by;
         my $col = COLUMNS->{$field}->{name};
         push(@groupby, $col) if !grep($_ eq $col, @groupby);
     }