From: Stefan Metzmacher <metze@samba.org>
Date: Tue, 11 Feb 2025 20:16:02 +0000 (+0100)
Subject: s4:auth: let authsam_make_user_info_dc() use helper variables for the rodcsid
X-Git-Tag: tevent-0.17.0~772
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8be527679122bdb3e72b1ddaa71f5cea153693d8;p=thirdparty%2Fsamba.git

s4:auth: let authsam_make_user_info_dc() use helper variables for the rodcsid

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
---

diff --git a/source4/auth/sam.c b/source4/auth/sam.c
index bf4cde4f886..cd4f6ef7159 100644
--- a/source4/auth/sam.c
+++ b/source4/auth/sam.c
@@ -673,6 +673,8 @@ _PUBLIC_ NTSTATUS authsam_make_user_info_dc(TALLOC_CTX *mem_ctx,
 
 	if ((info->acct_flags & (ACB_PARTIAL_SECRETS_ACCOUNT | ACB_WSTRUST)) ==
 	    (ACB_PARTIAL_SECRETS_ACCOUNT | ACB_WSTRUST)) {
+		struct dom_sid rodcsid = {};
+
 		/* the DOMAIN_RID_ENTERPRISE_READONLY_DCS PAC */
 		user_info_dc->sids = talloc_realloc(user_info_dc,
 						   user_info_dc->sids,
@@ -682,9 +684,11 @@ _PUBLIC_ NTSTATUS authsam_make_user_info_dc(TALLOC_CTX *mem_ctx,
 			TALLOC_FREE(user_info_dc);
 			return NT_STATUS_NO_MEMORY;
 		}
-		user_info_dc->sids[user_info_dc->num_sids].sid = *domain_sid;
-		sid_append_rid(&user_info_dc->sids[user_info_dc->num_sids].sid,
-			    DOMAIN_RID_ENTERPRISE_READONLY_DCS);
+
+		rodcsid = *domain_sid;
+		sid_append_rid(&rodcsid, DOMAIN_RID_ENTERPRISE_READONLY_DCS);
+
+		user_info_dc->sids[user_info_dc->num_sids].sid = rodcsid;
 		user_info_dc->sids[user_info_dc->num_sids].attrs = SE_GROUP_DEFAULT_FLAGS;
 		user_info_dc->num_sids++;
 	}