From: Julian Seward <jseward@acm.org>
Date: Fri, 19 Aug 2005 09:07:34 +0000 (+0000)
Subject: Fix signedness-of-char problem which caused this to segfault on ppc32-linux.
X-Git-Tag: svn/VALGRIND_3_1_0~562
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8be9f5eef7e722391b5f2f6c030cdc7e727041ac;p=thirdparty%2Fvalgrind.git

Fix signedness-of-char problem which caused this to segfault on ppc32-linux.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@4462
---

diff --git a/memcheck/tests/oset_test.c b/memcheck/tests/oset_test.c
index 7868f2c218..1b9ff1fced 100644
--- a/memcheck/tests/oset_test.c
+++ b/memcheck/tests/oset_test.c
@@ -10,7 +10,13 @@
 #include "pub_core_libcprint.h"
 
 // I need this to avoid some signedness warnings, not sure why
-#define Char char
+// #define Char char
+// jrs 19 Aug 2005: m_oset.c relies on Char being a signed char.
+// It appears that plain 'char' on ppc32 is unsigned and so the
+// above #define screws up the AVL tree balancing logic and
+// leads to segfaults.  Commenting it out and using the standard
+// definition of Char from pub_core_basics.h seems a good solution
+// as that has the same signedness on all platforms.
 
 // Crudely redirect various VG_(foo)() functions to their libc equivalents.
 #undef vg_assert