From: Marcin Siodelski Date: Thu, 2 Jun 2016 16:29:30 +0000 (+0200) Subject: [4318] Address review comments. X-Git-Tag: trac4106_update_base~7^2^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8bf71bd47aaedeb11660135a171c4fc34fc96a9d;p=thirdparty%2Fkea.git [4318] Address review comments. Better description of the DORA unit test configuration. --- diff --git a/src/bin/dhcp4/tests/dora_unittest.cc b/src/bin/dhcp4/tests/dora_unittest.cc index f8e980d281..644c6d4510 100644 --- a/src/bin/dhcp4/tests/dora_unittest.cc +++ b/src/bin/dhcp4/tests/dora_unittest.cc @@ -59,12 +59,18 @@ namespace { /// uses HW address for lease lookup, rather than client id /// /// - Configuration 4: -/// - The same as configuration 2, but using different values in -/// 'host-reservation-identifiers' +/// - Used for testing host reservations where circuit-id takes precedence +/// over hw-address, and the hw-address takes precedence over duid. +/// - 1 subnet: 10.0.0.0/24 +/// - 3 reservations for this subnet: +/// - IP address 10.0.0.7 for HW address aa:bb:cc:dd:ee:ff +/// - IP address 10.0.0.8 for DUID 01:02:03:04:05 +/// - IP address 10.0.0.9 for circuit-id 'charter950' /// /// - Configuration 5: -/// - The same as configuration 4, but using different values in -/// 'host-reservation-identifiers' +/// - The same as configuration 4, but using the following order of +/// host-reservation-identifiers: duid, circuit-id, hw-address. +/// const char* DORA_CONFIGS[] = { // Configuration 0 "{ \"interfaces-config\": {"