From: Shane Lontis <shane.lontis@oracle.com>
Date: Fri, 12 Mar 2021 02:53:14 +0000 (+1000)
Subject: Remove TODO in test/acvp_test.c related to setting AES-GCM iv.
X-Git-Tag: openssl-3.0.0-alpha14~289
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8bfb8f34580cac3a53b0ac88dec566c19d6c8c53;p=thirdparty%2Fopenssl.git

Remove TODO in test/acvp_test.c related to setting AES-GCM iv.

Fixes #14330

Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14525)
---

diff --git a/test/acvp_test.c b/test/acvp_test.c
index 0be26f699b4..cfed50b08d9 100644
--- a/test/acvp_test.c
+++ b/test/acvp_test.c
@@ -837,8 +837,9 @@ static int aes_gcm_enc_dec(const char *alg,
             goto err;
     }
     /*
-     * TODO(3.0): The IV should not be set outside the boundary as it is now.
-     * It needs to be fed in via a dummy entropy source for this test.
+     * For testing purposes the IV it being set here. In a compliant application
+     * the IV would be generated internally. A fake entropy source could also
+     * be used to feed in the random IV bytes (see fake_random.c)
      */
     if (!TEST_true(EVP_CipherInit_ex(ctx, NULL, NULL, key, iv, enc))
         || !TEST_true(EVP_CIPHER_CTX_set_padding(ctx, 0))