From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Fri, 31 Aug 2018 20:24:16 +0000 (-0400)
Subject: Run batch tests per backend
X-Git-Tag: rel_1_0_1~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8c2a0c82d908fc0daa0b0a1c7df2fe86f631ba0e;p=thirdparty%2Fsqlalchemy%2Falembic.git

Run batch tests per backend

Seeing a new unexpected success in limited scope for mysql,
correlating with addition of mariadb 10.3 to CI.  This test
should be producing db-specific successes/failures to track
it more easily

Change-Id: Ieacc640768caf98323c5652cb53189da2c43f553
---

diff --git a/tests/requirements.py b/tests/requirements.py
index 76629877..0be95eb3 100644
--- a/tests/requirements.py
+++ b/tests/requirements.py
@@ -170,6 +170,14 @@ class DefaultRequirements(SuiteRequirements):
             sqla_compat._mariadb_normalized_version_info(
                 config.db.dialect) > (10, 2)
 
+    def _mariadb_only_102(self, config):
+        return exclusions.against(config, "mysql") and \
+            sqla_compat._is_mariadb(config.db.dialect) and \
+            sqla_compat._mariadb_normalized_version_info(
+                config.db.dialect) >= (10, 2) and \
+            sqla_compat._mariadb_normalized_version_info(
+                config.db.dialect) < (10, 3)
+
     def _mysql_not_mariadb_102(self, config):
         return exclusions.against(config, "mysql") and (
             not sqla_compat._is_mariadb(config.db.dialect) or
diff --git a/tests/test_batch.py b/tests/test_batch.py
index 7ea1bcc1..99605d06 100644
--- a/tests/test_batch.py
+++ b/tests/test_batch.py
@@ -1448,6 +1448,7 @@ class BatchRoundTripTest(TestBase):
 
 class BatchRoundTripMySQLTest(BatchRoundTripTest):
     __only_on__ = "mysql"
+    __backend__ = True
 
     @exclusions.fails()
     def test_drop_pk_col_readd_pk_col(self):
@@ -1474,7 +1475,8 @@ class BatchRoundTripMySQLTest(BatchRoundTripTest):
     def test_create_drop_index(self):
         super(BatchRoundTripMySQLTest, self).test_create_drop_index()
 
-    @exclusions.fails_if(config.requirements._mariadb_102)
+    # fails on mariadb 10.2, succeeds on 10.3
+    @exclusions.fails_if(config.requirements._mariadb_only_102)
     def test_rename_column_boolean(self):
         super(BatchRoundTripMySQLTest, self).test_rename_column_boolean()
 
@@ -1489,6 +1491,7 @@ class BatchRoundTripMySQLTest(BatchRoundTripTest):
 
 class BatchRoundTripPostgresqlTest(BatchRoundTripTest):
     __only_on__ = "postgresql"
+    __backend__ = True
 
     @exclusions.fails()
     def test_drop_pk_col_readd_pk_col(self):