From: Andrew Tridgell <tridge@samba.org>
Date: Fri, 11 Sep 2009 07:13:28 +0000 (+1000)
Subject: s4-drs: actually call the new drsuapi_add_SPNs() code
X-Git-Tag: talloc-2.0.1~542
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8c58cef875b931cf6655d3b7002ed0a7fe32fe35;p=thirdparty%2Fsamba.git

s4-drs: actually call the new drsuapi_add_SPNs() code

An early return here didn't do any good :-)
---

diff --git a/source4/rpc_server/drsuapi/addentry.c b/source4/rpc_server/drsuapi/addentry.c
index ab190e1a795..4ccf14d93a4 100644
--- a/source4/rpc_server/drsuapi/addentry.c
+++ b/source4/rpc_server/drsuapi/addentry.c
@@ -105,7 +105,7 @@ static WERROR drsuapi_add_SPNs(struct drsuapi_bind_state *b_state,
 		el->values[0].length = strlen((char *)el->values[0].data);
 		el->values[1].data = (uint8_t *)talloc_asprintf(el->values, "ldap/%s/%s", 
 								ntds_guid_str, dom_string);
-		el->values[1].length = strlen((char *)el->values[0].data);
+		el->values[1].length = strlen((char *)el->values[1].data);
 
 		ret = ldb_modify(b_state->sam_ctx, msg);
 		if (ret != LDB_SUCCESS) {
@@ -173,7 +173,7 @@ WERROR dcesrv_drsuapi_DsAddEntry(struct dcesrv_call_state *dce_call, TALLOC_CTX
 		r->out.ctr->ctr3.count = num;
 		r->out.ctr->ctr3.objects = ids;
 
-		return WERR_OK;
+		break;
 	default:
 		return WERR_FOOBAR;
 	}