From: Sascha Steinbiss <satta@debian.org>
Date: Sat, 3 Aug 2024 13:05:20 +0000 (+0200)
Subject: rust/rfb: use consistent key name for security_result
X-Git-Tag: suricata-7.0.7~41
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8c8abbf7faeeaed5edd4deb7b39340fcd6218269;p=thirdparty%2Fsuricata.git

rust/rfb: use consistent key name for security_result

A typo caused a slightly different key (`security-result`) to be used
for the case in which the result was `FAIL`. This commit addresses this
by ensuring the same string is used for all cases.

Ticket: #7198
---

diff --git a/rust/src/rfb/logger.rs b/rust/src/rfb/logger.rs
index 62bb20966f..8c8e2ca2ed 100644
--- a/rust/src/rfb/logger.rs
+++ b/rust/src/rfb/logger.rs
@@ -67,12 +67,13 @@ fn log_rfb(tx: &RFBTransaction, js: &mut JsonBuilder) -> Result<(), JsonError> {
         _ => (),
     }
     if let Some(security_result) = &tx.tc_security_result {
+        let result_key = "security_result";
         let _ = match security_result.status {
-            0 => js.set_string("security_result", "OK")?,
-            1 => js.set_string("security-result", "FAIL")?,
-            2 => js.set_string("security_result", "TOOMANY")?,
+            0 => js.set_string(result_key, "OK")?,
+            1 => js.set_string(result_key, "FAIL")?,
+            2 => js.set_string(result_key, "TOOMANY")?,
             _ => js.set_string(
-                "security_result",
+                result_key,
                 &format!("UNKNOWN ({})", security_result.status),
             )?,
         };