From: Michael R Sweet <michael.r.sweet@gmail.com>
Date: Fri, 13 Dec 2019 14:30:46 +0000 (-0500)
Subject: CVE-2019-2228: Fix ippSetValueTag validation of default language.
X-Git-Tag: v2.2.13~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8c9b3606cca99e5dfc51784a9de1634345db7579;p=thirdparty%2Fcups.git

CVE-2019-2228: Fix ippSetValueTag validation of default language.
---

diff --git a/CHANGES.md b/CHANGES.md
index f8ce9f7f5c..46bd6aa6ae 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -1,10 +1,12 @@
-CHANGES - 2.2.13 - 2019-12-04
+CHANGES - 2.2.13 - 2019-12-13
 =============================
 
 
 Changes in CUPS v2.2.13
 -----------------------
 
+- CVE-2019-2228: The `ippSetValuetag` function did not validate the default
+  language value.
 - Added a workaround for the scheduler's systemd support (Issue #5640)
 - Fixed spelling of "fold-accordion".
 - Fixed the default common name for TLS certificates used by `ippserver`.
diff --git a/cups/ipp.c b/cups/ipp.c
index 7e325beb2f..dcc9d208b8 100644
--- a/cups/ipp.c
+++ b/cups/ipp.c
@@ -4568,7 +4568,7 @@ ippSetValueTag(
           return (0);
 
         if (ipp->attrs && ipp->attrs->next && ipp->attrs->next->name &&
-            !strcmp(ipp->attrs->next->name, "attributes-natural-language"))
+            !strcmp(ipp->attrs->next->name, "attributes-natural-language") && (ipp->attrs->next->value_tag & IPP_TAG_CUPS_MASK) == IPP_TAG_LANGUAGE)
         {
          /*
           * Use the language code from the IPP message...