From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 11 Dec 2020 15:37:49 +0000 (+0100)
Subject: rec: Copy the salt into the cache instead of taking a reference
X-Git-Tag: rec-4.5.0-alpha1~67^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8ca539e75a1b0cc8f43f7e2234357c857f9876bf;p=thirdparty%2Fpdns.git

rec: Copy the salt into the cache instead of taking a reference

At the moment the salt does live longer than the cache, but that
might hold true forever.
---

diff --git a/pdns/validate.cc b/pdns/validate.cc
index f97322a29f..9b70952284 100644
--- a/pdns/validate.cc
+++ b/pdns/validate.cc
@@ -80,7 +80,7 @@ static bool nsecProvesENT(const DNSName& name, const DNSName& begin, const DNSNa
   return begin.canonCompare(name) && next != name && next.isPartOf(name);
 }
 
-using nsec3HashesCache = std::map<std::tuple<DNSName, std::string&, uint16_t>, std::string>;
+using nsec3HashesCache = std::map<std::tuple<DNSName, std::string, uint16_t>, std::string>;
 
 static std::string getHashFromNSEC3(const DNSName& qname, const std::shared_ptr<NSEC3RecordContent>& nsec3, nsec3HashesCache& cache)
 {