From: Mike Bayer Date: Fri, 20 Jun 2025 17:04:54 +0000 (-0400) Subject: really pin flake8-import-order to <0.19 X-Git-Tag: rel_2_0_42~32 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8cb4bb0fd0ce648ba927300c91b254cee6f8ab72;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git really pin flake8-import-order to <0.19 In 8a287bf5c5635daf99217e I told @caselit to just omit 0.19.0, as I wa sure 0.19.1 would fix the issue. Unfortunately in [1] we see that this release continues to have problems, which seems to be related not to the importlib.metadata fix but to an unrelated improvement for TYPE_CHECKING blocks. So we really have to wait for them to get a working release before we can update. Change-Id: Ia82a98e836bed9e826906bd07827a9e00998bf7c --- diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 82184bbd53..06a3ef6366 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -16,7 +16,7 @@ repos: hooks: - id: flake8 additional_dependencies: - - flake8-import-order!=0.19.0 + - flake8-import-order<0.19 - flake8-import-single==0.1.5 - flake8-builtins - flake8-future-annotations>=0.0.5 diff --git a/tox.ini b/tox.ini index ee0bff23bb..54afe1dc11 100644 --- a/tox.ini +++ b/tox.ini @@ -240,7 +240,7 @@ extras= deps= flake8==7.2.0 - flake8-import-order!=0.19.0 + flake8-import-order<0.19 flake8-builtins flake8-future-annotations>=0.0.5 flake8-docstrings>=1.6.0