From: Jakub Jelinek <jakub@redhat.com>
Date: Fri, 9 Apr 2021 08:18:47 +0000 (+0200)
Subject: libgomp: Silence false positive -Wmaybe-uninitialized warning [PR99984]
X-Git-Tag: basepoints/gcc-12~182
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8cc863ca8f48662e9c9339710fa303587479bf71;p=thirdparty%2Fgcc.git

libgomp: Silence false positive -Wmaybe-uninitialized warning [PR99984]

pthread_setspecific second argument is const void *, so that one can
call it even with pointers to const, but the function only stores the
pointer and does nothing else, so the new assumption of -Wmaybe-uninitialized
that functions taking such pointers will read from what those pointers
will point to is wrong.  Maybe it would be useful to have some whitelist
of functions that surely don't do that.

Anyway, in this case it is easy to workaround the warning by moving the
pthread_setspecific call after the initialization without slowing anything
down.

2021-04-09  Jakub Jelinek  <jakub@redhat.com>

	PR libgomp/99984
	* team.c (gomp_thread_start): Call pthread_setspecific for
	!(defined HAVE_TLS || defined USE_EMUTLS) only after local_thr
	has been initialized to avoid false positive warning.
---

diff --git a/libgomp/team.c b/libgomp/team.c
index 96622345b103..ba57152db8a4 100644
--- a/libgomp/team.c
+++ b/libgomp/team.c
@@ -78,7 +78,6 @@ gomp_thread_start (void *xdata)
 #else
   struct gomp_thread local_thr;
   thr = &local_thr;
-  pthread_setspecific (gomp_tls_key, thr);
 #endif
   gomp_sem_init (&thr->release, 0);
 
@@ -92,6 +91,9 @@ gomp_thread_start (void *xdata)
 #ifdef GOMP_NEEDS_THREAD_HANDLE
   thr->handle = data->handle;
 #endif
+#if !(defined HAVE_TLS || defined USE_EMUTLS)
+  pthread_setspecific (gomp_tls_key, thr);
+#endif
 
   thr->ts.team->ordered_release[thr->ts.team_id] = &thr->release;