From: Simon Green <sgreen@redhat.com>
Date: Sat, 16 Feb 2013 21:58:00 +0000 (+0100)
Subject: Bug 840824: It is possible to create a new bug with a non active target milestone... 
X-Git-Tag: bugzilla-4.2.5~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8cd4a05a712a3513ae37ced423b7cabdf1730b30;p=thirdparty%2Fbugzilla.git

Bug 840824: It is possible to create a new bug with a non active target milestone, version or component
r/a=LpSolit
---

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index c557930b9b..9610acb7b8 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -1462,8 +1462,7 @@ sub _check_component {
     $name || ThrowUserError("require_component");
     my $product = blessed($invocant) ? $invocant->product_obj 
                                      : $params->{product};
-    my $old_comp = blessed($invocant) ? $invocant->component
-                                      : $params->{component};
+    my $old_comp = blessed($invocant) ? $invocant->component : '';
     my $object = Bugzilla::Component->check({ product => $product, name => $name });
     if ($object->name ne $old_comp && !$object->is_active) {
         ThrowUserError('value_inactive', { class => ref($object), value => $name });
@@ -1910,8 +1909,7 @@ sub _check_target_milestone {
     my ($invocant, $target, undef, $params) = @_;
     my $product = blessed($invocant) ? $invocant->product_obj 
                                      : $params->{product};
-    my $old_target = blessed($invocant) ? $invocant->target_milestone
-                                        : $params->{target_milestone};
+    my $old_target = blessed($invocant) ? $invocant->target_milestone : '';
     $target = trim($target);
     $target = $product->default_milestone if !defined $target;
     my $object = Bugzilla::Milestone->check(
@@ -1941,8 +1939,7 @@ sub _check_version {
     $version = trim($version);
     my $product = blessed($invocant) ? $invocant->product_obj 
                                      : $params->{product};
-    my $old_vers = blessed($invocant) ? $invocant->version
-                                      : $params->{version};
+    my $old_vers = blessed($invocant) ? $invocant->version : '';
     my $object = Bugzilla::Version->check({ product => $product, name => $version });
     if ($object->name ne $old_vers && !$object->is_active) {
         ThrowUserError('value_inactive', { class => ref($object), value => $version });