From: Aki Tuomi <aki.tuomi@open-xchange.com>
Date: Mon, 15 May 2023 06:23:31 +0000 (+0300)
Subject: lib-lua: Do not expect return value from script_init()
X-Git-Tag: 2.4.0~2762
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8d0b7607463c7391a305aef7e33821d96c4c86cc;p=thirdparty%2Fdovecot%2Fcore.git

lib-lua: Do not expect return value from script_init()

This is not really needed. Script can call error() if
they need to fail.
---

diff --git a/src/lib-lua/dlua-script.c b/src/lib-lua/dlua-script.c
index 487d02466a..63025d0b1b 100644
--- a/src/lib-lua/dlua-script.c
+++ b/src/lib-lua/dlua-script.c
@@ -174,22 +174,9 @@ int dlua_script_init(struct dlua_script *script, const char **error_r)
 
 	int ret = 0;
 
-	if (dlua_pcall(script->L, LUA_SCRIPT_INIT_FN, 0, 1, error_r) < 0)
+	if (dlua_pcall(script->L, LUA_SCRIPT_INIT_FN, 0, 0, error_r) < 0)
 		return -1;
 
-	if (lua_isinteger(script->L, -1)) {
-		ret = lua_tointeger(script->L, -1);
-		if (ret != 0) {
-			*error_r = "Script init failed";
-			ret = -1;
-		}
-	} else {
-		*error_r = LUA_SCRIPT_INIT_FN"() returned non-number";
-		ret = -1;
-	}
-
-	lua_pop(script->L, 1);
-
 	i_assert(lua_gettop(script->L) == 0);
 	return ret;
 }