From: Andreas Schneider <asn@samba.org>
Date: Tue, 24 Nov 2020 16:35:26 +0000 (+0100)
Subject: libcli:smb: Check return code of set_blocking
X-Git-Tag: samba-4.14.0rc1~568
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8d5d968ddef50831ea8e210986b01d5dd1630ffd;p=thirdparty%2Fsamba.git

libcli:smb: Check return code of set_blocking

Found by covscan.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/libcli/smb/smbXcli_base.c b/libcli/smb/smbXcli_base.c
index 3e020faca3c..df80be6bf16 100644
--- a/libcli/smb/smbXcli_base.c
+++ b/libcli/smb/smbXcli_base.c
@@ -338,7 +338,10 @@ struct smbXcli_conn *smbXcli_conn_create(TALLOC_CTX *mem_ctx,
 		return NULL;
 	}
 
-	set_blocking(fd, false);
+	ret = set_blocking(fd, false);
+	if (ret < 0) {
+		goto error;
+	}
 	conn->sock_fd = fd;
 
 	conn->remote_name = talloc_strdup(conn, remote_name);