From: Andreas Schneider <asn@samba.org>
Date: Wed, 29 Oct 2025 09:13:44 +0000 (+0100)
Subject: s3:client: Do not call exit() in cmd_quit()
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8d74ba4cb037abc393ea4a0603e41b8b09f98091;p=thirdparty%2Fsamba.git

s3:client: Do not call exit() in cmd_quit()

We want to go through deallocation in the main function.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
---

diff --git a/source3/client/client.c b/source3/client/client.c
index 1d10a4f90b2..162ab131b34 100644
--- a/source3/client/client.c
+++ b/source3/client/client.c
@@ -1472,9 +1472,10 @@ static bool do_altname(const char *name)
 static int cmd_quit(void)
 {
 	cli_shutdown(cli);
-	exit(0);
-	/* NOTREACHED */
-	return 0;
+	cli = NULL;
+
+	/* Use INT_MAX for QUIT */
+	return INT_MAX;
 }
 
 /****************************************************************************
@@ -5838,11 +5839,18 @@ static int process_command_string(const char *cmd_in)
 
 		if ((i = process_tok(tok)) >= 0) {
 			rc = commands[i].fn();
+			/* QUIT COMMAND */
+			if (rc == INT_MAX) {
+				TALLOC_FREE(tok);
+				rc = 0;
+				break;
+			}
 		} else if (i == -2) {
 			d_printf("%s: command abbreviation ambiguous\n",tok);
 		} else {
 			d_printf("%s: command not found\n",tok);
 		}
+		TALLOC_FREE(tok);
 	}
 
 	return rc;
@@ -6201,6 +6209,13 @@ static int process_stdin(void)
 
 		if ((i = process_tok(tok)) >= 0) {
 			rc = commands[i].fn();
+			/* QUIT COMMAND */
+			if (rc == INT_MAX) {
+				rc = 0;
+				SAFE_FREE(line);
+				TALLOC_FREE(tok);
+				break;
+			}
 		} else if (i == -2) {
 			d_printf("%s: command abbreviation ambiguous\n",tok);
 		} else {
@@ -6247,7 +6262,7 @@ static int process(const char *base_directory)
 	if (cmdstr) {
 		rc = process_command_string(cmdstr);
 	} else {
-		process_stdin();
+		rc = process_stdin();
 	}
 
 	cli_shutdown(cli);