From: Frantisek Sumsal <frantisek@sumsal.cz>
Date: Thu, 11 Apr 2024 09:35:17 +0000 (+0200)
Subject: test: make the output of TEST-69 less painful to read
X-Git-Tag: v256-rc1~222^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8d9cdb31f7cc41bb2252be70a2410030551aabde;p=thirdparty%2Fsystemd.git

test: make the output of TEST-69 less painful to read

The logs from TEST-69 still contain a lot of unnecessary shell
metacharacters, so to make the output more readable let's just set
TERM=dumb, instead of having to strip everything semi-manually. Also,
move the related --background= tweak to TEST-69, since it's relevant
only for that particular test.

Follow-up for 8d4bfd38ed941aa8003d7007145eccc01f52a5f6.
---

diff --git a/test/TEST-69-SHUTDOWN/test.sh b/test/TEST-69-SHUTDOWN/test.sh
index 0e12857618d..0229d896d41 100755
--- a/test/TEST-69-SHUTDOWN/test.sh
+++ b/test/TEST-69-SHUTDOWN/test.sh
@@ -17,7 +17,7 @@ SYSTEMD_NSPAWN="${STATEDIR:?}/run-nspawn"
 setup_nspawn_root_hook() {
     cat >"${STATEDIR:?}/run-nspawn" <<EOF
 #!/bin/bash
-exec "${TEST_BASE_DIR:?}/test-shutdown.py" -v -- "$_ORIG_NSPAWN" "\$@"
+exec "${TEST_BASE_DIR:?}/test-shutdown.py" -v -- "$_ORIG_NSPAWN" --background= "\$@"
 exit 1
 EOF
     chmod 755 "${STATEDIR:?}"/run-nspawn
diff --git a/test/test-functions b/test/test-functions
index 33575d3b3ae..c62cf3d5218 100644
--- a/test/test-functions
+++ b/test/test-functions
@@ -662,7 +662,6 @@ run_nspawn() {
         "--directory=${1:?}"
         "--setenv=SYSTEMD_UNIT_PATH=/usr/lib/systemd/tests/testdata/testsuite-$2.units:/usr/lib/systemd/tests/testdata/units:"
         "--machine=TEST-$TESTID"
-        "--background=''"
     )
     local kernel_params=(
         "$PATH_TO_INIT"
diff --git a/test/test-shutdown.py b/test/test-shutdown.py
index 870c1e269f5..d19a03742c2 100755
--- a/test/test-shutdown.py
+++ b/test/test-shutdown.py
@@ -12,7 +12,6 @@ import pexpect
 
 
 def run(args):
-
     ret = 1
     logger = logging.getLogger("test-shutdown")
     logfile = None
@@ -25,7 +24,7 @@ def run(args):
 
     logger.info("spawning test")
     console = pexpect.spawn(args.command, args.arg, logfile=logfile, env={
-            "TERM": "linux",
+            "TERM": "dumb",
         }, encoding='utf-8', timeout=60)
 
     logger.debug("child pid %d", console.pid)