From: Mark Andrews <marka@isc.org>
Date: Fri, 23 Jan 2026 03:30:44 +0000 (+1100)
Subject: Fix and call tsig_badsig unit test
X-Git-Tag: v9.21.18~12^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8da2310511c26c1d0264c028aed12bda48376c44;p=thirdparty%2Fbind9.git

Fix and call tsig_badsig unit test
---

diff --git a/tests/dns/tsig_test.c b/tests/dns/tsig_test.c
index b07dcd27abe..ca938751578 100644
--- a/tests/dns/tsig_test.c
+++ b/tests/dns/tsig_test.c
@@ -419,7 +419,16 @@ tsig_tcp(isc_stdtime_t now, isc_result_t expected_result, bool mangle_sig) {
 		assert_int_equal(msg->verified_sig, 1);
 		assert_int_equal(msg->tsigstatus, dns_tsigerror_badtime);
 		break;
+	case DNS_R_TSIGVERIFYFAILURE:
+		assert_int_equal(result, DNS_R_TSIGVERIFYFAILURE);
+		assert_int_equal(msg->verified_sig, 0);
+		assert_int_equal(msg->tsigstatus, dns_tsigerror_badsig);
+		break;
 	default:
+		if (debug) {
+			fprintf(stderr, "# result = %s\n",
+				isc_result_totext(result));
+		}
 		UNREACHABLE();
 	}
 
@@ -471,7 +480,7 @@ ISC_RUN_TEST_IMPL(tsig_badtime) {
 }
 
 ISC_RUN_TEST_IMPL(tsig_badsig) {
-	tsig_tcp(isc_stdtime_now(), DNS_R_TSIGERRORSET, true);
+	tsig_tcp(isc_stdtime_now(), DNS_R_TSIGVERIFYFAILURE, true);
 }
 
 /* Tests the dns__tsig_algvalid function */
@@ -490,9 +499,10 @@ ISC_RUN_TEST_IMPL(algvalid) {
 }
 
 ISC_TEST_LIST_START
-ISC_TEST_ENTRY(tsig_tcp)
-ISC_TEST_ENTRY(tsig_badtime)
 ISC_TEST_ENTRY(algvalid)
+ISC_TEST_ENTRY(tsig_badsig)
+ISC_TEST_ENTRY(tsig_badtime)
+ISC_TEST_ENTRY(tsig_tcp)
 ISC_TEST_LIST_END
 
 ISC_TEST_MAIN