From: Alan T. DeKok <aland@freeradius.org>
Date: Fri, 5 Jan 2024 14:29:35 +0000 (-0500)
Subject: more xlat cleanups
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8e09052e50d00ddbc63eab12540a9021b2c3e4e8;p=thirdparty%2Ffreeradius-server.git

more xlat cleanups
---

diff --git a/src/tests/modules/cipher/serial.unlang b/src/tests/modules/cipher/serial.unlang
index c70b069f9f0..c49920ae2bd 100644
--- a/src/tests/modules/cipher/serial.unlang
+++ b/src/tests/modules/cipher/serial.unlang
@@ -1,4 +1,4 @@
-&Tmp-Octets-0 := "%(cipher_rsa.certificate:serial)"
+&Tmp-Octets-0 := %cipher_rsa.certificate('serial')
 
 if (%length(%{Tmp-Octets-0}) != 1) {
 	test_fail
diff --git a/src/tests/modules/eap_sim/sim_xlat_id_aka_decrypt_no_tag.unlang b/src/tests/modules/eap_sim/sim_xlat_id_aka_decrypt_no_tag.unlang
index db4dd87803c..43d8c746d44 100644
--- a/src/tests/modules/eap_sim/sim_xlat_id_aka_decrypt_no_tag.unlang
+++ b/src/tests/modules/eap_sim/sim_xlat_id_aka_decrypt_no_tag.unlang
@@ -15,7 +15,7 @@ if (%aka_sim_id_type(%{User-Name}) != 'permanent') {
 #
 #  1.2 - Get the original IMSI back again sans tag
 #
-&control.Tmp-String-1 := "%(3gpp_temporary_id_decrypt:%{control.User-Name} %{control.Tmp-String-0} false)"
+&control.Tmp-String-1 := %3gpp_temporary_id_decrypt(%{control.User-Name}, %{control.Tmp-String-0}, 'false')
 
 if ("%{User-Name}" =~ /^0(.*)/) {
 	if (!&control.Tmp-String-1 || (&control.Tmp-String-1 == '') || (%{control.Tmp-String-1} != "%{1}")) {
diff --git a/src/tests/modules/exec/sync.unlang b/src/tests/modules/exec/sync.unlang
index 3fd6167c69a..1fa17147fb0 100644
--- a/src/tests/modules/exec/sync.unlang
+++ b/src/tests/modules/exec/sync.unlang
@@ -1,7 +1,7 @@
 #
 #  Sync calls return the response
 #
-&Tmp-String-0 := "%(exec_sync:/bin/sh -c 'echo hello')"
+&Tmp-String-0 := %exec_sync('/bin/sh', '-c', "echo 'hello'")
 if (&Tmp-String-0 != 'hello') {
 	test_fail
 }
@@ -10,20 +10,24 @@ if (&Tmp-String-0 != 'hello') {
 #  Call something which will take longer than the timeout
 #
 &request -= &Tmp-String-0
-&Tmp-String-0 := "%(exec_sync:/bin/sleep 10)"
+&request -= &Module-Failure-Message
 
-if (&Module-Failure-Message[*] != "Execution of external program failed: Timeout running program") {
+&Tmp-String-0 := %exec_sync('/bin/sleep', '10')
+
+if (&Module-Failure-Message != "Execution of external program failed: Timeout running program") {
 	test_fail
 }
 
-if !(&Tmp-String-0 == "") {
+if &Tmp-String-0  {
 	test_fail
 }
 
 &request -= &Tmp-String-0
-&Tmp-String-0 := "%(exec_sync:/bin/sh $ENV{MODULE_TEST_DIR}/fail.sh)"
+&request -= &Module-Failure-Message
+
+&Tmp-String-0 := %exec_sync('/bin/sh', "$ENV{MODULE_TEST_DIR}/fail.sh")
 
-if !(&Tmp-String-0 == "") {
+if &Tmp-String-0 {
 	test_fail
 }
 
diff --git a/src/tests/modules/unbound/dns.unlang b/src/tests/modules/unbound/dns.unlang
index a91f20af033..bee7dc199cb 100644
--- a/src/tests/modules/unbound/dns.unlang
+++ b/src/tests/modules/unbound/dns.unlang
@@ -5,20 +5,20 @@ if (&Tmp-IP-Address-0 != 127.0.0.1) {
 	test_fail
 }
 
-&Tmp-String-0 := "%(dns:localhost AAAA)"
+&Tmp-String-0 := %dns('localhost', 'AAAA')
 
 if (&Tmp-String-0 != "::1") {
 	test_fail
 }
 
-&Tmp-String-1 := %dns(1.0.0.127.in-addr.arpa,PTR)
+&Tmp-String-1 := %dns(1.0.0.127.in-addr.arpa, 'PTR')
 
 if (&Tmp-String-1 != "localhost") {
 	test_fail
 }
 
 #  Use local data in module config to allow for dotted names
-&Tmp-IP-Address-0 := %dns(www.example.com,A)
+&Tmp-IP-Address-0 := %dns('www.example.com', 'A')
 
 if (&Tmp-IP-Address-0 != 192.168.1.1) {
 	test_fail
@@ -32,27 +32,27 @@ if (&Tmp-String-0 != "www.example.com") {
 
 # Try a real, known, network response
 # Temporarily disabled while there is a bug in unbound
-#&Tmp-String-0 := %dns(8.8.8.8.in-addr.arpa,PTR)
+#&Tmp-String-0 := %dns('8.8.8.8.in-addr.arpa', 'PTR')
 
 #if (&Tmp-String-0 != "dns.google") {
 #	test_fail
 #}
 
 # Invalid query
-&Tmp-String-0 := %dns(www.example.com,ABC)
+&Tmp-String-0 := %dns('www.example.com', 'ABC')
 
 if (&Module-Failure-Message != "Invalid / unsupported DNS query type") {
 	test_fail
 }
 
 &Tmp-String-0 := ""
-&Tmp-String-1 := %dns(%{Tmp-String-0},A)
+&Tmp-String-1 := %dns(%{Tmp-String-0}, 'A')
 
 if (&Module-Failure-Message != "Can't resolve zero length host") {
 	test_fail
 }
 
-&Tmp-String-1 := "%dns(example.com,MX)"
+&Tmp-String-1 := %dns('example.com', 'MX')
 
 # Until we can handle multiple boxes in xlat expansion, the results
 # are concatenated into a single string