From: Miod Vallat <miod.vallat@powerdns.com>
Date: Fri, 4 Jul 2025 13:29:03 +0000 (+0200)
Subject: Tweak boolean logic to make it more readable.
X-Git-Tag: rec-5.3.0-alpha2^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8e1e34ae179d28fd861316f264ad80f8167f8da5;p=thirdparty%2Fpdns.git

Tweak boolean logic to make it more readable.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---

diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc
index 8409dc0c07..54777030b5 100644
--- a/modules/lmdbbackend/lmdbbackend.cc
+++ b/modules/lmdbbackend/lmdbbackend.cc
@@ -2752,11 +2752,12 @@ bool LMDBBackend::updateDNSSECOrderNameAndAuth(domainid_t domain_id, const DNSNa
     newRRs.reserve(lrrs.size());
     for (auto& lrr : lrrs) {
       lrr.qtype = compoundOrdername::getQType(key.getNoStripHeader<StringView>());
-      if (!needNSEC3 && qtype != QType::ANY) {
-        needNSEC3 = (lrr.hasOrderName && QType(qtype) != lrr.qtype);
+      bool isDifferentQType = qtype != QType::ANY && QType(qtype) != lrr.qtype;
+      if (!needNSEC3) {
+        needNSEC3 = lrr.hasOrderName && isDifferentQType;
       }
 
-      if ((qtype == QType::ANY || QType(qtype) == lrr.qtype) && (lrr.hasOrderName != hasOrderName || lrr.auth != auth)) {
+      if (!isDifferentQType && (lrr.hasOrderName != hasOrderName || lrr.auth != auth)) {
         lrr.auth = auth;
         lrr.hasOrderName = hasOrderName;
         changed = true;