From: David Allan <dallan@redhat.com>
Date: Mon, 24 Jan 2011 20:47:52 +0000 (-0500)
Subject: Do not use virtio-serial port 0 for generic ports
X-Git-Tag: v0.8.8~137
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8e28c5d40200b4c5d483bd585d237b9d870372e5;p=thirdparty%2Flibvirt.git

Do not use virtio-serial port 0 for generic ports

Per the discussion in:

https://bugzilla.redhat.com/show_bug.cgi?id=670394

The port numbering should start from 1, not 0.  We assign maxport + 1,
so start maxport at 0.
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index d5445a40a0..08c21e5fa5 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -5328,7 +5328,7 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps,
 
         if (chr->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL &&
             chr->info.addr.vioserial.port == 0) {
-            int maxport = -1;
+            int maxport = 0;
             int j;
             for (j = 0 ; j < i ; j++) {
                 virDomainChrDefPtr thischr = def->channels[j];