From: Peter Krempa <pkrempa@redhat.com>
Date: Mon, 25 Oct 2021 14:11:49 +0000 (+0200)
Subject: qemublocktest: Don't leak 'disk' in testQemuImageCreateLoadDiskXML
X-Git-Tag: v7.9.0-rc1~19
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8e3a7c6db990d0e43a765d3ba9e89b920a4e4364;p=thirdparty%2Flibvirt.git

qemublocktest: Don't leak 'disk' in testQemuImageCreateLoadDiskXML

The function returns only the source portion but forgot to free the disk
wrapper.

Fixes: 9696427ad67196
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/tests/qemublocktest.c b/tests/qemublocktest.c
index 0176fbd3f4..9d3c2fe6b0 100644
--- a/tests/qemublocktest.c
+++ b/tests/qemublocktest.c
@@ -473,7 +473,7 @@ testQemuImageCreateLoadDiskXML(const char *name,
                                virDomainXMLOption *xmlopt)
 
 {
-    virDomainDiskDef *disk = NULL;
+    g_autoptr(virDomainDiskDef) disk = NULL;
     g_autofree char *xmlpath = NULL;
     g_autofree char *xmlstr = NULL;
 
@@ -490,7 +490,7 @@ testQemuImageCreateLoadDiskXML(const char *name,
     if (qemuDomainDeviceDiskDefPostParse(disk, 0) < 0)
         return NULL;
 
-    return disk->src;
+    return g_steal_pointer(&disk->src);
 }