From: Jason Merrill <jason@redhat.com>
Date: Wed, 19 Oct 2011 22:22:25 +0000 (-0400)
Subject: re PR c++/50793 (G++ doesn't value-initialize all members of non-trivial type in... 
X-Git-Tag: releases/gcc-4.5.4~392
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8e676ce9dd4bce163bbedd3df78a8007c88489de;p=thirdparty%2Fgcc.git

re PR c++/50793 (G++ doesn't value-initialize all members of non-trivial type in default argument)

	PR c++/50793
	* tree.c (bot_manip): Propagate AGGR_INIT_ZERO_FIRST.

From-SVN: r180226
---

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index f4da489d6e95..c61269d97ee7 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,8 @@
+2011-10-19  Jason Merrill  <jason@redhat.com>
+
+	PR c++/50793
+	* tree.c (bot_manip): Propagate AGGR_INIT_ZERO_FIRST.
+
 2011-10-13  Jason Merrill  <jason@redhat.com>
 
 	PR c++/50618
diff --git a/gcc/cp/tree.c b/gcc/cp/tree.c
index c80fa995634f..c52ae22ffff2 100644
--- a/gcc/cp/tree.c
+++ b/gcc/cp/tree.c
@@ -1732,7 +1732,11 @@ bot_manip (tree* tp, int* walk_subtrees, void* data)
       tree u;
 
       if (TREE_CODE (TREE_OPERAND (t, 1)) == AGGR_INIT_EXPR)
-	u = build_cplus_new (TREE_TYPE (t), TREE_OPERAND (t, 1));
+	{
+	  u = build_cplus_new (TREE_TYPE (t), TREE_OPERAND (t, 1));
+	  if (AGGR_INIT_ZERO_FIRST (TREE_OPERAND (t, 1)))
+	    AGGR_INIT_ZERO_FIRST (TREE_OPERAND (u, 1)) = true;
+	}
       else
 	u = build_target_expr_with_type (TREE_OPERAND (t, 1), TREE_TYPE (t));
 
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index fb50220228a5..b408e258443f 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2011-10-19  Jason Merrill  <jason@redhat.com>
+
+	PR c++/50793
+	* g++.dg/init/value9.C: New.
+
 2011-10-13  Jason Merrill  <jason@redhat.com>
 
 	PR c++/50618
diff --git a/gcc/testsuite/g++.dg/init/value9.C b/gcc/testsuite/g++.dg/init/value9.C
new file mode 100644
index 000000000000..4899bd81001a
--- /dev/null
+++ b/gcc/testsuite/g++.dg/init/value9.C
@@ -0,0 +1,32 @@
+// PR c++/50793
+// { dg-do run }
+
+struct NonTrivial
+{
+  NonTrivial() { }
+};
+
+struct S
+{
+  NonTrivial nt;
+  int i;
+};
+
+int f(S s)
+{
+  s.i = 0xdeadbeef;
+  return s.i;
+}
+
+int g(S s = S())
+{
+  return s.i;
+}
+
+int main()
+{
+  f(S());  // make stack dirty
+
+  if ( g() )
+    __builtin_abort();
+}