From: Michael Tremer <michael.tremer@ipfire.org>
Date: Fri, 20 May 2022 17:34:16 +0000 (+0000)
Subject: package: Simply empty string check
X-Git-Tag: 0.9.28~774
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8e76ebe15091eaba332c5e3de369590baf663b46;p=pakfire.git

package: Simply empty string check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/package.c b/src/libpakfire/package.c
index d5634a8f8..1afbba18d 100644
--- a/src/libpakfire/package.c
+++ b/src/libpakfire/package.c
@@ -316,16 +316,13 @@ static void pakfire_package_set_num(struct pakfire_package* pkg, Id type, unsign
 	solvable_set_num(s, type, value);
 }
 
-static const char* pakfire_package_get_string(struct pakfire_package* pkg, int key) {
+static const char* pakfire_package_get_string(struct pakfire_package* pkg, Id key) {
 	pakfire_package_internalize_repo(pkg);
 
 	Solvable* s = get_solvable(pkg);
-	const char* str = solvable_lookup_str(s, key);
-
-	if (!str)
-		return NULL;
 
-	if (strlen(str) == 0)
+	const char* str = solvable_lookup_str(s, key);
+	if (!str || !*str)
 		return NULL;
 
 	return str;