From: Bob Halley <halley@dnspython.org>
Date: Tue, 11 Aug 2020 14:42:07 +0000 (-0700)
Subject: lint
X-Git-Tag: v2.1.0rc1~89
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8e7f887a6d482c61b3c745f34c02fcbf07faaaf7;p=thirdparty%2Fdnspython.git

lint
---

diff --git a/dns/immutable.py b/dns/immutable.py
index 7cc39dd0..db7abbcc 100644
--- a/dns/immutable.py
+++ b/dns/immutable.py
@@ -32,12 +32,13 @@ class Dict(collections.abc.Mapping):
     def __getitem__(self, key):
         return self._odict.__getitem__(key)
 
-    def __hash__(self):
+    def __hash__(self):  # pylint: disable=invalid-hash-returned
         if self._hash is None:
             h = 0
             for key in sorted(self._odict.keys()):
                 h ^= hash(key)
             object.__setattr__(self, '_hash', h)
+        # this does return an int, but pylint doesn't figure that out
         return self._hash
 
     def __len__(self):
diff --git a/dns/versioned.py b/dns/versioned.py
index 45ede79b..cc2f7148 100644
--- a/dns/versioned.py
+++ b/dns/versioned.py
@@ -201,7 +201,7 @@ class Zone(dns.zone.Zone):
         self._write_waiters = collections.deque()
         self._commit_version_unlocked(WritableVersion(self), origin)
 
-    def reader(self, id=None, serial=None):
+    def reader(self, id=None, serial=None):  # pylint: disable=arguments-differ
         if id is not None and serial is not None:
             raise ValueError('cannot specify both id and serial')
         with self.version_lock: