From: lpsolit%gmail.com <>
Date: Tue, 15 May 2007 00:27:16 +0000 (+0000)
Subject: Bug 379787: Flag request mail has a blank requestee when requestee doesn't get the... 
X-Git-Tag: bugzilla-3.0.1~81
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8e8532756ecaa3543f5c41b90d1af9ecc1be8ec1;p=thirdparty%2Fbugzilla.git

Bug 379787: Flag request mail has a blank requestee when requestee doesn't get the mail - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked r=myk a=LpSolit
---

diff --git a/Bugzilla/Flag.pm b/Bugzilla/Flag.pm
index c3981d92bb..7473ea1f1a 100644
--- a/Bugzilla/Flag.pm
+++ b/Bugzilla/Flag.pm
@@ -746,6 +746,7 @@ sub modify {
             my $requester;
             if ($flag->status eq '?') {
                 $requester = $flag->setter;
+                $flag->{'requester'} = $requester;
             }
             # Now update the flag object with its new values.
             $flag->{'setter'} = $setter;
@@ -905,6 +906,7 @@ sub clear {
     my $requester;
     if ($flag->status eq '?') {
         $requester = $flag->setter;
+        $flag->{'requester'} = $requester;
     }
 
     # Now update the flag object to its new values. The last
diff --git a/template/en/default/request/email.txt.tmpl b/template/en/default/request/email.txt.tmpl
index a5fd17b883..9dddbe8454 100644
--- a/template/en/default/request/email.txt.tmpl
+++ b/template/en/default/request/email.txt.tmpl
@@ -27,12 +27,14 @@
 [% attidsummary = attachment.id _ ': ' _ attachment.description %]
 [% statuses = { '+' => "granted" , '-' => 'denied' , 'X' => "canceled" ,
                 '?' => "asked" } %]
+
+[% to_identity = "" %]
 [% IF flag.status == '?' %]
-  [% to_identity = flag.addressee.identity _ " for" %]
+  [% to_identity = flag.requestee.identity _ " for" %]
   [% subject_status = "requested" %]
 [% ELSE %]
-  [% IF flag.addressee %]
-    [% to_identity = flag.addressee.identity _ "'s request for" %]
+  [% IF flag.requester %]
+    [% to_identity = flag.requester.identity _ "'s request for" %]
   [% END %]
   [% subject_status = statuses.${flag.status} %]
 [% END %]