From: Tobias Brunner <tobias@strongswan.org>
Date: Wed, 16 Dec 2015 10:53:01 +0000 (+0100)
Subject: pki: Never print more than MAX_LINES of usage summary
X-Git-Tag: 5.4.0dr2~10^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8ea64a78d65807c8496e9d089f18af001aeb932d;p=thirdparty%2Fstrongswan.git

pki: Never print more than MAX_LINES of usage summary

Print a warning if a registered command exceeds that limit.
---

diff --git a/src/pki/command.c b/src/pki/command.c
index 13e81404c9..ce704dbb82 100644
--- a/src/pki/command.c
+++ b/src/pki/command.c
@@ -172,6 +172,15 @@ void command_register(command_t command)
 				"options",	'+', 1, "read command line options from file"
 			};
 		}
+		for (i = 0; cmds[registered].line[i]; i++)
+		{
+			if (i == MAX_LINES - 1)
+			{
+				fprintf(stderr, "command '%s' specifies too many usage summary "
+						"lines, please increase MAX_LINES\n", command.cmd);
+				break;
+			}
+		}
 	}
 	registered++;
 }
@@ -208,7 +217,7 @@ int command_usage(char *error)
 	}
 	else
 	{
-		for (i = 0; cmds[active].line[i]; i++)
+		for (i = 0; i < MAX_LINES && cmds[active].line[i]; i++)
 		{
 			if (i == 0)
 			{